<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> </head> <body> <p>Hi, David.<br> </p> <div class="moz-cite-prefix">On 11/3/23 17:37, David Edelsohn wrote:<br> </div> <blockquote type="cite" cite="mid:CAGWvnynOWoKT1EWkL8ELfRVxSUjm-hBQnnjb-w2Gq-tmOFm0Hg@mail.gmail.com"> <meta http-equiv="content-type" content="text/html; charset=UTF-8"> <div dir="ltr"> <pre id="gmail-b" style="font-size:13px;background-image:initial;background-position:initial;background-size:initial;background-repeat:initial;background-origin:initial;background-clip:initial;color:rgb(0,0,51)">Dual-license drm_gpuvm to GPL-2.0 OR MIT.</pre> <pre id="gmail-b" style="font-size:13px;background-image:initial;background-position:initial;background-size:initial;background-repeat:initial;background-origin:initial;background-clip:initial;color:rgb(0,0,51)"><div class="gmail-head" style="font-weight:bold;margin-top:1em;color:black;font-size:13.3333px">diff --git a/drivers/gpu/drm/drm_gpuvm.c b/drivers/gpu/drm/drm_gpuvm.c index 02ce6baacdad..08c088319652 100644 --- a/<a href="https://cgit.freedesktop.org/drm/drm-misc/tree/drivers/gpu/drm/drm_gpuvm.c?id=6f2eeef4a0aa9791bbba9d353641a6e067bb86c1" style="color:blue;text-decoration-line:none" moz-do-not-send="true">drivers/gpu/drm/drm_gpuvm.c</a> +++ b/<a href="https://cgit.freedesktop.org/drm/drm-misc/tree/drivers/gpu/drm/drm_gpuvm.c?id=f7749a549b4f4db0c02e6b3d3800ea400dd76c12" style="color:blue;text-decoration-line:none" moz-do-not-send="true">drivers/gpu/drm/drm_gpuvm.c</a></div><div class="gmail-hunk" style="color:rgb(0,0,153);font-size:13.3333px">@@ -1,4 +1,4 @@</div><div class="gmail-del" style="color:red;font-size:13.3333px">-// SPDX-License-Identifier: GPL-2.0-only</div><div class="gmail-add" style="color:green;font-size:13.3333px">+// SPDX-License-Identifier: GPL-2.0 OR MIT</div><div class="gmail-ctx" style="color:rgb(51,51,51);font-size:13.3333px"> /*</div><div class="gmail-ctx" style="color:rgb(51,51,51);font-size:13.3333px"> * Copyright (c) 2022 Red Hat.</div><div class="gmail-ctx" style="color:rgb(51,51,51);font-size:13.3333px"> *</div><div class="gmail-ctx" style="color:rgb(51,51,51);font-size:13.3333px"> </div><div class="gmail-ctx" style="color:rgb(51,51,51);font-size:13.3333px"><font face="arial, sans-serif">The above SPDX License Identifier change is incorrect and no longer</font></div><div class="gmail-ctx" style="color:rgb(51,51,51);font-size:13.3333px"><font face="arial, sans-serif">valid. The change misunderstood the syntax of SPDX license identifiers</font></div><div class="gmail-ctx" style="color:rgb(51,51,51);font-size:13.3333px"><font face="arial, sans-serif">and boolean operations. GPL-2.0-only is the name of the license and means</font></div><div class="gmail-ctx" style="color:rgb(51,51,51);font-size:13.3333px"><font face="arial, sans-serif">GPL 2.0 only, as opposed to GPL 2.0 or later. The "only" does not</font></div><div class="gmail-ctx" style="color:rgb(51,51,51);font-size:13.3333px"><font face="arial, sans-serif">refer to restrictions on other licenses in the identifier and should not have been</font></div><div class="gmail-ctx" style="color:rgb(51,51,51);font-size:13.3333px"><font face="arial, sans-serif">removed. The hyphens designated that the name was a single unit.</font></div><div class="gmail-ctx" style="color:rgb(51,51,51);font-size:13.3333px"><font face="arial, sans-serif">The SPDX License Identifier boolean operators, such as OR, are a separate layer</font></div><div class="gmail-ctx" style="color:rgb(51,51,51);font-size:13.3333px"><font face="arial, sans-serif">of syntax. </font></div><div class="gmail-ctx" style="color:rgb(51,51,51);font-size:13.3333px"><font face="arial, sans-serif"> </font></div><div class="gmail-ctx" style="color:rgb(51,51,51);font-size:13.3333px"><font face="arial, sans-serif">The SPDX License Identifier should be</font></div><div class="gmail-ctx" style="color:rgb(51,51,51);font-size:13.3333px"><font face="arial, sans-serif"> </font></div><div class="gmail-ctx" style="color:rgb(51,51,51);font-size:13.3333px"><font face="arial, sans-serif">GPL-2.0-only OR MIT</font></div><div class="gmail-ctx" style="color:rgb(51,51,51);font-size:13.3333px"><font face="arial, sans-serif"> </font></div><div class="gmail-ctx" style="color:rgb(51,51,51);font-size:13.3333px"><font face="arial, sans-serif">Thanks, David</font></div></pre> </div> </blockquote> <p>The author has acked the change / relicensing, which is also described in the commit title so could you please elaborate why you think it is not valid?</p> <p>Thanks,</p> <p>Thomas</p> <p><br> </p> <p><br> </p> </body> </html>