[PATCH] dolt: Add sparc*-*-linux to "-fPIC" cases.

Josh Triplett josh at joshtriplett.org
Fri Apr 16 21:59:52 PDT 2010

On Fri, Apr 16, 2010 at 03:59:32PM -0700, David Miller wrote:
> Tested with builds of libX11 and xserver.
> Signed-off-by: David S. Miller <davem at davemloft.net>
> diff --git a/dolt.m4 b/dolt.m4
> index 8f94582..3f3691f 100644
> --- a/dolt.m4
> +++ b/dolt.m4
> @@ -22,7 +22,7 @@ if test x$GCC != xyes; then
>      dolt_supported=no
>  fi
>  case $host in
> -i?86-*-linux*|x86_64-*-linux*|powerpc-*-linux* \
> +i?86-*-linux*|x86_64-*-linux*|powerpc-*-linux*|sparc*-*-linux \
>  |amd64-*-freebsd*|i?86-*-freebsd*|ia64-*-freebsd*)
>      pic_options='-fPIC'
>      ;;

Shouldn't this say sparc*-*-linux* to handle hosts like *-linux-gnu?

Also, do you happen to know if this conditional could just become
*-*-linux*?  I tried to write it as carefully as possible to err on the
side of caution, and I don't want to handle a platform incorrectly, but
if all Linux platforms will always use -fPIC and nothing else for shared
libraries then I could just make that change once rather than once for
every new platform.

- Josh Triplett

More information about the dolt mailing list