[PATCH] drm_handle_t type
Matthew W. S. Bell
matthew at bells23.org.uk
Wed Apr 14 09:15:26 PDT 2010
On Tue, 2010-04-13 at 22:32 -0500, Robert Noland wrote:
> On Wed, 2010-04-14 at 00:19 +0100, Matthew W. S. Bell wrote:
> > On Sun, 2010-04-11 at 09:10 -0500, Robert Noland wrote:
> > > On Sat, 2010-04-10 at 19:30 +0100, Matthew W. S. Bell wrote:
> > > > On Mon, 2010-04-05 at 17:46 +1000, Dave Airlie wrote:
> > > > > Its probably not documented well anywhere, though I think the handles are
> > > > > 32-bit is written down somewhere.
> > > >
> > > > Ah sorry, I missed some.
> > >
> > > drm_handle_t is correct here...
> >
> > No, drm_handle_t can be of a different size to void *; converting
> > between integers and pointers of different sizes causes a warning. To
> > eliminate the warning, the value first needs to be passed between
> > uintptr_t and void *, which are of the same size, and then converted to
> > drm_handle_t. The last part is implicit; the drm_handle_t casts are
> > irrelevant/useless.
>
> My point being that the casts to drm_handle_t are correct. Feel free to
> fix linux' define for drm_handle_t.
Warnings; warnings. The point is to get rid of the warnings. warnings?
Did I mention that when compiling a warning is emitted? Warnings. This
code just silences the warnings.
Warnings.
Matthew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20100414/38d16410/attachment.pgp>
More information about the dri-devel
mailing list