[PATCH 1/2] drm/edid: Make EDID header fixup threshold configurable

[Adam Jackson]

On Tue, 2010-04-27 at 15:01 +1000, Dave Airlie wrote:
> On Tue, Apr 27, 2010 at 5:03 AM, Adam Jackson <ajax at redhat.com> wrote:
> > Signed-off-by: Adam Jackson <ajax at redhat.com>
> 
> not sure about the kernel-parameters additions, since the option would
> be drm.edid_threshhold= and its a module option, though now that we
> can accept module options on the command line, we could start adding
> them to parameters file. However you'd need to add the drm. bit to the
> front of the option.

The doc already kind of mentions that, but it's kind of wrong.  It only
talks about "passing options with modprobe" and "passing options to
built-in modules on kcmdline", but not about "passing options to
loadable modules on kcmdline".  I'll follow up on that to lkml.

> How much broken hw we seeing that this fixes? maybe some bug
> references, as I hate having special options that people have to know
> just to see somehting on screen.

I've seen at least two cases in bug reports.  I could dig up a reference
I suppose.

That's a valid point though: we currently don't distinguish between
"connected but with broken EDID" and "disconnected".  I think it sounds
reasonable to treat the former as connector_status_unknown instead.
That way, if nothing else is connected, X will still light you up at the
fallback size.  Sound right?

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20100427/b4eb2612/attachment.pgp>