[PATCH 09/11] drm: replace drawable ioctl by noops

[Michel Dänzer]

On Don, 2010-04-29 at 11:14 +0200, Daniel Vetter wrote: 
> The information supplied by userspace through these ioctls is only
> accessible by dev->drw_idr. But there's no in-tree user of that.
> Information might also leak via the RM_DRAW ioctl (in the form of
> a negative return code in case the drawable doesn't exist). But the
> only user of these ioctls, mesas' miniglx, does not use the RM_DRAW
> ioctl.

FYI, the X server DRI1 code also uses these ioctls, via the libdrm
functions drmCreate/DestroyDrawable and drmUpdateDrawableInfo().

> Therefore it's safe to replace these three ioctls with noops and rip
> out the implementation.

That should still true though, as none of the DRM drivers use the
drawable cliprect information anymore. Might still be worth
double-checking that this doesn't break DRI without KMS on your RV570.


-- 
Earthling Michel Dänzer           |                http://www.vmware.com
Libre software enthusiast         |          Debian, X and DRI developer