[PATCH 14/14] drm: kill agp indirection mess

Daniel Vetter daniel at ffwll.ch
Tue Aug 24 09:20:00 PDT 2010


On Tue, Aug 24, 2010 at 11:05:04AM -0400, Kristian Høgsberg wrote:
> >  /** Wrapper around agp_unbind_memory() */
> >  int drm_unbind_agp(DRM_AGP_MEM * handle)
> >  {
> > -       return drm_agp_unbind_memory(handle);
> > +       return agp_unbind_memory(handle);
> >  }
> >  EXPORT_SYMBOL(drm_unbind_agp);
> 
> Any reason to keep these last three wrappers around?

That would amount to completely ripping out the drm agp abstraction
(including DRM_AGP_MEM #defines and friends). A decently-sized patch
series touching lots of drivers, drm core (for the generic mapping stuff)
and the innards of ttm/gem.

But yeah, if people want this I can certainly prep patches. There's
already

#define DRM_AGP_MEM		struct agp_memory
#define DRM_AGP_KERN		struct agp_kern_info

so the whole thing can be accomplished without a flag day.

> Kristian

Cheers, Daniel

-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48


More information about the dri-devel mailing list