[PATCH 3/3] drm/radeon/kms: enable writeback on remaing asics

Alex Deucher alexdeucher at gmail.com
Fri Aug 27 15:04:55 PDT 2010


On Fri, Aug 27, 2010 at 7:15 AM, Joshua Roys <roysjosh at gmail.com> wrote:
> On Fri, Aug 6, 2010 at 9:37 PM, Alex Deucher <alexdeucher at gmail.com> wrote:
>> +++ b/drivers/gpu/drm/radeon/r300.c
>> @@ -1332,6 +1332,12 @@ static int r300_startup(struct radeon_device *rdev)
>>                if (r)
>>                        return r;
>>        }
>> +
>> +       /* allocate wb buffer */
>> +       radeon_wb_init(rdev);
>> +       if (r)
>> +               return r;
>> +
>>        /* Enable IRQ */
>>        r100_irq_set(rdev);
>>        rdev->config.r300.hdp_cntl = RREG32(RADEON_HOST_PATH_CNTL);
>
> Hello,
>
> Should this be "r = radeon_wb_init(rdev);" ?  It looks like all calls
> of this function in this patch (and the r6xx/r7xx/evergreen one) could
> use this addition.
>

Yup.  fixed up in new patch.

> Thanks,
>
> Josh
>


More information about the dri-devel mailing list