[stable] [PATCH] drm/kms: remove spaces from connector names

Dave Airlie airlied at gmail.com
Wed Dec 8 15:32:29 PST 2010


On Thu, Dec 9, 2010 at 9:30 AM, Greg KH <greg at kroah.com> wrote:
> On Wed, Dec 08, 2010 at 06:14:03PM -0500, Alex Deucher wrote:
>> Grub doesn't parse spaces in parameters correctly, so
>> this makes it impossible to force video= parameters
>> for kms on the grub kernel command line.
>>
>> Reported-by: Sergej Pupykin <ml at sergej.pp.ru>
>>
>> Cc: Sergej Pupykin <ml at sergej.pp.ru>
>> Signed-off-by: Alex Deucher <alexdeucher at gmail.com>
>> Cc: stable at kernel.org
>> ---
>>  drivers/gpu/drm/drm_crtc.c |    8 ++++----
>>  1 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
>> index 6985cb1..7ee7a2f 100644
>> --- a/drivers/gpu/drm/drm_crtc.c
>> +++ b/drivers/gpu/drm/drm_crtc.c
>> @@ -156,12 +156,12 @@ static struct drm_conn_prop_enum_list drm_connector_enum_list[] =
>>       { DRM_MODE_CONNECTOR_SVIDEO, "SVIDEO", 0 },
>>       { DRM_MODE_CONNECTOR_LVDS, "LVDS", 0 },
>>       { DRM_MODE_CONNECTOR_Component, "Component", 0 },
>> -     { DRM_MODE_CONNECTOR_9PinDIN, "9-pin DIN", 0 },
>
> What kernel version did these options first show up in?  Does any
> other tools rely on the spaces?

No, X doesn't use the names and I can't think of anything shipped that
uses the interfaces that would care.

Dave.


More information about the dri-devel mailing list