[stable] [PATCH] drm/kms: remove spaces from connector names

Jesse Barnes jbarnes at virtuousgeek.org
Thu Dec 9 09:46:23 PST 2010


On Thu, 09 Dec 2010 20:33:18 +0300
Sergej Pupykin <ml at sergej.pp.ru> wrote:

> At Thu, 9 Dec 2010 09:18:14 -0800,
> Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> > 
> > On Wed, 8 Dec 2010 15:30:26 -0800
> > Greg KH <greg at kroah.com> wrote:
> > > What kernel version did these options first show up in?  Does any
> > > other tools rely on the spaces?
> > 
> > And it's ugly; can't we fix grub instead?
> 
> I think renaming connectors is good idea anyway. It should be typed
> before system boot, so names should be short and easy kept in mind.
> 
> Such as TV, DIN, VGA, DVI, etc...

I prefer to keep the user visible names as they are, they're
descriptive and easy to read with spaces.

An alternative to fixing grub would be to add aliases like you mention,
and/or change the parser to accept "_" as an alias for " ".  Then we
could leave the sysfs values and string table alone.

-- 
Jesse Barnes, Intel Open Source Technology Center


More information about the dri-devel mailing list