[PATCH] [correction] load fbcon from drm_kms_helper
mickler at fzi.de
Sun Dec 12 14:01:28 PST 2010
On Sun, 12 Dec 2010 12:39:22 -0600
David Fries <david at fries.net> wrote:
> Kconfig says fbcon is required by drm_kms_helper. If radeon, fbcon,
> and drm_kms_helper are all modules, radeon is auto loaded (by PCI id?),
> drm_kms_helper is loaded because of the module dependency, but fbcon
> isn't loaded leaving the console unusable. Since fbcon is required
> and there isn't an explicit module dependency, request the module
> to be loaded from drm_kms_helper.
> Signed-off-by: David Fries <david at fries.net>
> Cc: David Airlie <airlied at linux.ie>
> Cc: dri-devel at lists.freedesktop.org
> The last patch had a typo 'namue', mental reminder, test again after
> running checkpatch.pl.
> This solves compiling CONFIG_FB=m and being left with a blank screen
> because the radeon module is automatically loaded, but fbcon isn't.
> If radeon had to be manually loaded, then it would be the user's fault
> not loading fbcon as well, but as radeon is being loaded
> there isn't much a user can do from console to even fix it. More bug
> details from here,
I guess this is reasonable. Maybe _if_ there actually is a usecase for
a drm driver without fbcon, the drm could provide a
parameter to skip loading fbcon?
But also the drm Kconfig seems to be bogus? SELECT is not transitiv.
So selecting DRM_KMS_HELPER is not enough, as it will not select FB
and FRAMEBUFFER_CONSOLE. Maybe the drm drivers that currently
select DRM_KMS_HELPER should instead depend on it.
More information about the dri-devel