[PATCH] drm/radeon/kms/pm: add support for SetVoltage cmd table (V2)

[Rafał Miłecki]

2010/5/28 Alex Deucher <alexdeucher at gmail.com>:
> diff --git a/drivers/gpu/drm/radeon/r600.c b/drivers/gpu/drm/radeon/r600.c
> index dac2534..d84d7cf 100644
> --- a/drivers/gpu/drm/radeon/r600.c
> +++ b/drivers/gpu/drm/radeon/r600.c
> @@ -475,6 +475,12 @@ void r600_pm_init_profile(struct radeon_device *rdev)
>
>  void r600_pm_misc(struct radeon_device *rdev)
>  {
> +       int requested_index = rdev->pm.requested_power_state_index;
> +       struct radeon_power_state *ps = &rdev->pm.power_state[requested_index];
> +       struct radeon_voltage *voltage = &ps->clock_info[0].voltage;
> +
> +       if ((voltage->type == VOLTAGE_SW) && voltage->voltage)
> +               radeon_atom_set_voltage(rdev, voltage->voltage);
>
>  }
>

In case of my RV620 I can see (using AtomDis):
    0004:  UCHAR ucVoltageType                                 = 0x01       (1)
so it looks that my GPU uses VOLTAGE_GPIO (it's 0x01).

You seem to do not use SetVoltage AtomBIOS command for VOLTAGE_GPIO.
However in case of my BIOS there is SetVoltage command table.

Could you comment on this, please?

-- 
Rafał