[PATCH 1/8]reiserfs:stree.c Fix variable set but not used.
Justin P. Mattock
justinmattock at gmail.com
Mon Jun 14 14:09:58 PDT 2010
On 06/14/2010 01:48 PM, Nick Bowler wrote:
> On 13:26 Mon 14 Jun , Justin P. Mattock wrote:
>> @@ -617,8 +616,7 @@ int search_by_key(struct super_block *sb, const struct cpu_key *key, /* Key to s
>>
>> pathrelse(search_path);
>>
>> - right_neighbor_of_leaf_node = 0;
>> -
>> +
>
> This hunk introduces whitespace on the empty line, which is not cool.
I can resend!!(biggest problem is working
through these warnings)
>
>> /* With each iteration of this loop we search through the items in the
>> current node, and calculate the next current node(next path element)
>> for the next iteration of this loop.. */
>> @@ -695,8 +693,7 @@ int search_by_key(struct super_block *sb, const struct cpu_key *key, /* Key to s
>> starting from the root. */
>> block_number = SB_ROOT_BLOCK(sb);
>> expected_level = -1;
>> - right_neighbor_of_leaf_node = 0;
>> -
>> +
>
> Here, too.
>
> Most of the patches in this series have similar issues.
>
main thing now(for me atleast)is,
is this actual dead code or what?
if not then something else needs to
be done, if yes then I guess I can
resend this, with out the whitespace
issue.
Justin P. Mattock
More information about the dri-devel
mailing list