[Ksummit-2010-discuss] [v2] Remaining BKL users, what to do

Pekka Enberg penberg at kernel.org
Fri Nov 5 00:14:02 PDT 2010


On Fri, Nov 5, 2010 at 4:27 AM, Arnd Bergmann <arnd at arndb.de> wrote:
> On Wednesday 03 November 2010, Pekka Enberg wrote:
>> On Tue, Nov 2, 2010 at 3:21 AM, Pavel Machek <pavel at ucw.cz> wrote:
>> > Hi!
>> >
>> >> @@ -79,6 +79,10 @@ static struct drm_driver driver = {
>> >>
>> >>  static int __init i810_init(void)
>> >>  {
>> >> +     if (num_present_cpus() > 1) {
>> >> +             pr_err("drm/i810 does not support SMP\n");
>> >> +             return -EINVAL;
>> >> +     }
>> >>       driver.num_ioctls = i810_max_ioctl;
>> >>       return drm_init(&driver);
>> >
>> > Umm, and now someone onlines second cpu?
>>
>> Well, I see it's being fixed in a different way but yeah,
>> num_possible_cpus() would be more appropriate here.
>
> (trimming Cc list again)
>
> I thought that patch was still current, what other way are we fixing it now?

Oh, I just read the thread wrong. If you repost with
num_possible_cpus, feel free to add my ACK.


More information about the dri-devel mailing list