[PATCH] drm/radeon/kms: i2c s/sprintf/snprintf/g for safety

[Jean Delvare]

On Thu, 18 Nov 2010 11:37:18 -0500, Alex Deucher wrote:
> As per advice from Jean Delvare.
> 
> Signed-off-by: Alex Deucher <alexdeucher at gmail.com>
> Cc: Jean Delvare <khali at linux-fr.org>

Thanks Alex.

Acked-by: Jean Delvare <khali at linux-fr.org>

> ---
>  drivers/gpu/drm/radeon/radeon_i2c.c |    9 ++++++---
>  1 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/radeon/radeon_i2c.c b/drivers/gpu/drm/radeon/radeon_i2c.c
> index d263bd1..ded2a45 100644
> --- a/drivers/gpu/drm/radeon/radeon_i2c.c
> +++ b/drivers/gpu/drm/radeon/radeon_i2c.c
> @@ -896,7 +896,8 @@ struct radeon_i2c_chan *radeon_i2c_create(struct drm_device *dev,
>  	     ((rdev->family <= CHIP_RS480) ||
>  	      ((rdev->family >= CHIP_RV515) && (rdev->family <= CHIP_R580))))) {
>  		/* set the radeon hw i2c adapter */
> -		sprintf(i2c->adapter.name, "Radeon i2c hw bus %s", name);
> +		snprintf(i2c->adapter.name, sizeof(i2c->adapter.name),
> +			 "Radeon i2c hw bus %s", name);
>  		i2c->adapter.algo = &radeon_i2c_algo;
>  		ret = i2c_add_adapter(&i2c->adapter);
>  		if (ret) {
> @@ -905,7 +906,8 @@ struct radeon_i2c_chan *radeon_i2c_create(struct drm_device *dev,
>  		}
>  	} else {
>  		/* set the radeon bit adapter */
> -		sprintf(i2c->adapter.name, "Radeon i2c bit bus %s", name);
> +		snprintf(i2c->adapter.name, sizeof(i2c->adapter.name),
> +			 "Radeon i2c bit bus %s", name);
>  		i2c->adapter.algo_data = &i2c->algo.bit;
>  		i2c->algo.bit.pre_xfer = pre_xfer;
>  		i2c->algo.bit.post_xfer = post_xfer;
> @@ -946,7 +948,8 @@ struct radeon_i2c_chan *radeon_i2c_create_dp(struct drm_device *dev,
>  	i2c->rec = *rec;
>  	i2c->adapter.owner = THIS_MODULE;
>  	i2c->dev = dev;
> -	sprintf(i2c->adapter.name, "Radeon aux bus %s", name);
> +	snprintf(i2c->adapter.name, sizeof(i2c->adapter.name),
> +		 "Radeon aux bus %s", name);
>  	i2c_set_adapdata(&i2c->adapter, i2c);
>  	i2c->adapter.algo_data = &i2c->algo.dp;
>  	i2c->algo.dp.aux_ch = radeon_dp_i2c_aux_ch;


-- 
Jean Delvare