[Intel-gfx] [PATCH 2/2] drm/i915: Use pipe state to tell when pipe is off

Jesse Barnes jbarnes at virtuousgeek.org
Sun Oct 3 08:10:48 PDT 2010

On Sun,  3 Oct 2010 00:33:06 -0700
Keith Packard <keithp at keithp.com> wrote:

> Instead of waiting for the display line value to settle, we can simply
> wait for the pipe configuration register 'state' bit to turn off.
> Contrarywise, disabling the plane will not cause the display line
> value to stop changing, so instead we wait for the vblank interrupt
> bit to get set. And, we only do this when we're not about to wait for
> the pipe to turn off.
> Signed-off-by: Keith Packard <keithp at keithp.com>
> ---

Do these fixes help with the DP issues you've been seeing, Keith?
Seems like the first one shouldn't change behavior since we ought to
time out on waiting on vblank in that case, and the timeout is the same
as the msleep we used to use.

The second one looks like a good change, but really the pipe off change
is separate from the plane disable bug fix.

Jesse Barnes, Intel Open Source Technology Center

More information about the dri-devel mailing list