[PATCH] drm/i915: Free hardware status page on unload when physically mapped

Chris Wilson chris at chris-wilson.co.uk
Thu Oct 7 01:19:06 PDT 2010

On Thu, 07 Oct 2010 15:43:43 +1000, Dave Airlie <airlied at redhat.com> wrote:
> On Wed, 2010-10-06 at 21:24 -0700, Keith Packard wrote:
> > A physically mapped hardware status page is allocated at driver load
> > time but was never freed. Call the existing code to free this page at
> > driver unload time on hardware which uses this kind.
> the free_hws gets called after we disappear the mmio mapping for the
> registers. it then writes a register after killing the hws, and oopses.

Right, freeing the hws page is a definite oversight. It looks like we
should only be doing so on the KMS-only path anyway which neatly pulls the
call before the mmio teardown.

Applied with the amendment to -next.

Chris Wilson, Intel Open Source Technology Centre

More information about the dri-devel mailing list