Feedback: BKL / radeon pageflipping patches / DRM Vblank timestamping patches. 1st Try.

Tue Oct 26 06:32:01 PDT 2010

Hi,

today, I started with testing "DRM Vblank timestamping patches. 1st
Try." from Mario in combination with "radeon pageflipping patches"
from Alex together in a non-BKL config Kernel-setup.

First some words to my system and hardware:
* It's a Debian/sid i386 host with latest dist-upgrades as of today.
* My radeon gfxcard is a RV250.

[ Linux-kernel ]

* Base is a 2.6.36 vanilla Linux-kernel tarball
* on top linux-next (next-20101026) with some extra-patches to be able
to build a BKL-free Kernel (Thanks Arnd)
* on top drm-radeon-testing (up to commit 881fe6c: "drm/radeon/kms:
properly compute group_size on 6xx/7xx")
* Mario's vblank timestamp caching patches (Rev 1 10.10.2010) with
some patches to fit linux-next/drm-radeon-testing
* Alex's radeon-KMS pageflipping patches for Kernel
* For full patch-series see below

NOTE: My Linux-kernel has one speciality: It is BigKerneLock-free !

[ DDX (xf66-video-ati) ]

* xf86-video-ati from GIT master (up to commit df92245: "r100: add
some missing bits in SE_COORD_FMT")
* on top Alex's radeon-KMS pageflipping patch for DDX

NOTE from Alex in [2]: "6xx/7xx/evergreen are pretty solid, but
r1xx-r5xx still need some work."

[ Mesa3D ]

* it is from GIT master (up to commit 547e761: "egl_dri2: Fix a typo
that make glFlush be called at wrong time.")

[ LibDRM ]

* 2.4.22-1 from Debian/experimental

[ Xorg-server ]
* 2:1.9.0.902-1 from Debian/experimental

So, how we know Mario made us happy (BTW, greetings from TUE to TUE)?

[ dmesg ]
[    8.195646] [drm] Supports vblank timestamp caching Rev 1
(10.10.2010). <--- Driver-date could be changed into more
human-readable "10-Oct-2010"?

What about the fun Alex gives us?

[ /var/log/Xorg.0.log ]
[  1797.204] (II) RADEON(0): KMS Pageflipping: enabled

INFO:
I have attached the full dmesg and a Xorg.log (with logs after having
started Eric Anholt's OpenArena benchmark).

Above mentionned OA-benchmark drops fps from ~18 down to 13 (new
Kernel + new DDX).
I have not tested battery performance.

My notebook's LVDS has a 1400x1050 resolution, OA was run @1024x768.
Can you enlighten a bit on the other mesages in X log?

[ /var/log/Xorg.0.log ]
...
[  2069.700] (II) RADEON(0): Allocate new frame buffer 1024x768 stride
1024 <---- Start OpenArena benchmark
[  2069.700] (II) RADEON(0): VRAM usage limit set to 50788K
[  2072.150] (II) RADEON(0): radeon_dri2_schedule_flip:571 fevent[0x849e988]
[  2072.160] (II) RADEON(0): radeon_dri2_flip_event_handler:927
fevent[0x849e988] width 1024 pitch 4096 (/4 1024)
[  2072.178] (II) RADEON(0): radeon_dri2_schedule_flip:571 fevent[0x8c83298]
...
[  2082.364] (II) RADEON(0): Allocate new frame buffer 1400x1056
stride 1408 <--- Switch back to native resolution (end of benchmark)
[  2082.364] (II) RADEON(0): VRAM usage limit set to 48326K
...

Hope, this feedback is helpful and encourages the diverse involved
developers to continue their work.
Have fun!

Kind Regards,
- Sedat -

[1] http://lists.freedesktop.org/archives/dri-devel/2010-October/005009.html
[2] http://lists.freedesktop.org/archives/dri-devel/2010-October/005036.html
[3] http://git.kernel.org/?p=linux/kernel/git/arnd/bkl.git;a=summary
[4] http://people.freedesktop.org/~agd5f/pflip/

[ setup_linux-next_next-20101026.1.log ]
...
--> Try to apply base.
  (+) OK   linux-next/patch-v2.6.36-next-20101026
  (+) OK   linux-next/0001-Remove-localversion-next.patch
  (+) OK   for-linux-next/fs-remove-BKL-from-FILE_LOCKING-v2.patch
  (+) OK   for-linux-next/drm-i810-remove-SMP-support-and-BKL.patch
  (+) OK   drm-radeon-testing/drm-radeon-testing.patch
  (+) OK   drm-vblank-timestamping/1-3-drm-vblank-Add-support-for-precise-vblank-timestamping.patch
  (+) OK   drm-vblank-timestamping/2-3-kms-radeon-Add-support-for-precise-vblank-timestamping.patch
  (+) OK   drm-vblank-timestamping/drm-i915-fix-assignment-obj_priv-to_intel_bo.patch
  (+) OK   drm-vblank-timestamping/3-3-kms-i915-Add-support-for-precise-vblank-timestamping.patch
  (+) OK   drm-vblank-timestamping/drm-i915-fix-error-implicit-declaration-of-function-IS_IRONLAKE.patch
  (+) OK   agd5f_pflip/0001-drm-radeon-kms-add-support-for-pflip-interrupts-on-6.patch
  (+) OK   agd5f_pflip/0002-drm-radeon-kms-add-pageflip-ioctl-support.patch
  (+) OK   linux-kbuild/1-2-Kbuild-Treat-KBUILD_DEFCONFIG-old-as-request-to-use-.config-as-the-base.patch
  (+) OK   linux-kbuild/2-2-Kbuild-kconfig-Verbose-version-of---listnewconfig-and---defconfig-v2.patch
  (+) OK   x86-apic-fix/Skip-looking-for-ioapic-overrides-when-ioapics-are-not-present.patch
  (+) OK   debian/version.patch
  (+) OK   debian/kernelvariables.patch
  (+) OK   debian/doc-build-parallel.patch
  (+) OK   debian/piix-disable-redundant-devids.patch
  (+) OK   bugfix/ia64/hardcode-arch-script-output.patch
  (+) OK   bugfix/mips/disable-advansys.patch
  (+) OK   bugfix/arm/disable-scsi_acard.patch
  (+) OK   debian/mips-disable-werror.patch
  (+) OK   bugfix/powerpc/lpar-console.patch
  (+) OK   features/all/i915-autoload-without-CONFIG_DRM_I915_KMS.patch
  (+) OK   debian/sysrq-mask.patch
  (+) OK   debian/arch-sh4-fix-uimage-build.patch
  (+) OK   bugfix/mips/mips-ide-flush-dcache.patch
--> base fully applied.
...
- EOT -
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dmesg_drm-Supports-vblank-timestamp-caching-Rev-1-10.10.2010
Type: application/octet-stream
Size: 53991 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20101026/95ee6ef1/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Xorg.0.log_RADEON-0-KMS-Pageflipping-enabled
Type: application/octet-stream
Size: 82307 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20101026/95ee6ef1/attachment-0003.obj>