[PATCH] drm/i915/sdvo: Fix harmless build warning
Peter Stuge
peter at stuge.se
Sat Oct 30 04:30:29 PDT 2010
Dongdong Deng wrote:
> Removing the following harmless build warning to let compiler happy.
> @@ -1170,7 +1170,8 @@ static void intel_sdvo_mode_set(struct drm_encoder *encoder,
> switch (sdvo_pixel_multiply) {
> case 1: rate = SDVO_CLOCK_RATE_MULT_1X; break;
> case 2: rate = SDVO_CLOCK_RATE_MULT_2X; break;
> - case 4: rate = SDVO_CLOCK_RATE_MULT_4X; break;
> + case 4:
> + default: rate = SDVO_CLOCK_RATE_MULT_4X;
> }
> if (!intel_sdvo_set_clock_rate_mult(intel_sdvo, rate))
> return;
Even if the default case can not trigger, is 4x a good default multiplier?
Also, shouldn't there be a break; also in the default: case?
//Peter
More information about the dri-devel
mailing list