Interlace modes with r600 KMS

Alex Deucher alexdeucher at gmail.com
Tue Sep 7 12:00:30 PDT 2010


2010/9/7 Marius Gröger <marius.groeger at googlemail.com>:
> Am 07.09.2010 17:53, schrieb Alex Deucher:
>>
>> It did in the past, however, at the moment, I don't have a interlaced
>> capable monitor to test.  Can you try again with xf86-video-ati from
>> git master?
>
> No change, at all, unfortunately. The interlace modes, while listed in
> Xorg.conf, are not visible in xrandr. Manually adding an interlaced mode
> with xrandr results in a broken screen display.
>
> Any other thoughts?
>

Does this patch help?

diff --git a/drivers/gpu/drm/radeon/radeon_encoders.c
b/drivers/gpu/drm/radeon/radeon_encoders.c
index 2c293e8..f821247 100644
--- a/drivers/gpu/drm/radeon/radeon_encoders.c
+++ b/drivers/gpu/drm/radeon/radeon_encoders.c
@@ -288,8 +288,8 @@ static bool radeon_atom_mode_fixup(struct
drm_encoder *encoder,
        drm_mode_set_crtcinfo(adjusted_mode, 0);

        /* hw bug */
-       if ((mode->flags & DRM_MODE_FLAG_INTERLACE)
-           && (mode->crtc_vsync_start < (mode->crtc_vdisplay + 2)))
+       if ((adjusted_mode->flags & DRM_MODE_FLAG_INTERLACE)
+           && (adjusted_mode->crtc_vsync_start <
(adjusted_mode->crtc_vdisplay + 2)))
                adjusted_mode->crtc_vsync_start =
adjusted_mode->crtc_vdisplay + 2;

        /* get the native mode for LVDS */


If not, does it work ok with ums (boot with radeon.modeset=0)?  If so,
we'll need to compare the modesetting paths between ums and kms and
see what got broken with kms.

Alex

> Regards
> Marius
>
>


More information about the dri-devel mailing list