[drm-fixes] drm/vmwgfx: error: too few arguments to function ‘vmw_ldu_connector_detect’ in vmw_ldu_connector_detect()

Sedat Dilek sedat.dilek at googlemail.com
Tue Sep 14 02:38:22 PDT 2010


Hi,

I pulled drm-fixes GIT branch into mainline.

Unfortunately, the build breaks:
...
...
  CC [M]  drivers/gpu/drm/vmwgfx/vmwgfx_ldu.o
  /home/sd/src/linux-2.6/linux-2.6.36-rc4/debian/build/source_i386_none/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c:
In function ‘vmw_ldu_init’:
  /home/sd/src/linux-2.6/linux-2.6.36-rc4/debian/build/source_i386_none/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c:520:
error: too few arguments to function ‘vmw_ldu_connector_detect’
  /home/sd/src/linux-2.6/linux-2.6.36-rc4/debian/build/source_i386_none/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c:
In function ‘vmw_kms_ldu_update_layout’:
  /home/sd/src/linux-2.6/linux-2.6.36-rc4/debian/build/source_i386_none/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c:614:
error: too few arguments to function ‘vmw_ldu_connector_detect’
  make[4]: *** [drivers/gpu/drm/vmwgfx/vmwgfx_ldu.o] Error 1
  make[3]: *** [drivers/gpu/drm/vmwgfx] Error 2
  make[2]: *** [_module_drivers/gpu/drm] Error 2
  make[1]: *** [sub-make] Error 2
  make: *** [all] Error 2

As far as I can see the cause aroses from:

  commit 7b334fcb45b757ffb093696ca3de1b0c8b4a33f1
  "drm: Use a nondestructive mode for output detect when polling"

Looks like vmw_ldu_connector_detect(connector); needs to be enhanced
with "bool nondestructive".

Kind Regards,
- Sedat -


More information about the dri-devel mailing list