[PATCH] nouveau build regression, undefined reference to `acpi_video_get_edid'

[Phil Turmel]

Francisco Jerez wrote:
> Phil Turmel <philip at turmel.org> writes:

[snip /]

>> Having the nouveau ACPI features depend on CONFIG_ACPI_VIDEO instead of
>> bare CONFIG_ACPI builds, boots, and works for me.

> nouveau_acpi_edid() is the only function that depends on ACPI_VIDEO,
> ifdef'ing out the rest of the ACPI stuff in that case doesn't make much
> sense to me.

Understood.  I noticed that DRM_I915 does a "select ACPI_VIDEO if ACPI",
which is why I mentioned that alternative below.  I don't recall how I got
the y+m combination above (I tend to build stuff in), but a randconfig
could certainly hit this.  I intend to leave it y+y when I'm done.

>> Presumably, this could also be solved by adding
>> "select ACPI_VIDEO if ACPI" to the nouveau Kconfig.
>> I'd be happy to try that, if this approach is flawed.

I'll test the Kconfig approach later today.

Regards,

Phil Turmel