[PATCH] drm/i915/lvds: Only act on lid notify when the device is on

Chris Wilson chris at chris-wilson.co.uk
Thu Apr 21 23:26:48 PDT 2011

On Fri, 22 Apr 2011 16:13:27 +1000, Dave Airlie <airlied at gmail.com> wrote:
> On Fri, Apr 22, 2011 at 3:58 PM, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> > On Thu, 21 Apr 2011 16:08:14 -0600, Alex Williamson <alex.williamson at redhat.com> wrote:
> >> If we're using vga switcheroo, the device may be turned off
> >> and poking at it can cause an oops.
> >
> > I'm unfamiliar with what actually happens here after it is turned off. Can
> > you post an OOPS for an example?
> The device will be in D3, so I'm guessing we read back some register
> and get 0xFFFFFFFF,
> and later fail.

That's sounds reasonable. A bit of explanation does wonders if I (or
anyone else reading through the history *or* code) ever encounter
similar bug reports.

Is anyone else concerned by the acpi_lid_notifier never being decoupled
when the module is unloaded? And the randomness of int_lvds_connector?

I love our code, every time you read it you find another bug.

Chris Wilson, Intel Open Source Technology Centre

More information about the dri-devel mailing list