[PATCH v3] pass ELD to HDMI/DP audio driver

Keith Packard keithp at keithp.com
Wed Aug 3 19:48:08 PDT 2011

On Mon, 1 Aug 2011 21:51:40 +0800, Wu Fengguang <fengguang.wu at intel.com> wrote:

> 1) intel_write_eld() is not called at all
>    It seems we need to call intel_write_eld() in other places besides
>    inside ->mode_set(). Is ->detect() the right place to do so? In
>    other words, are there established connector<=>encoder mapping
>    that can be queried inside intel_hdmi_detect()/intel_dp_detect()?

The connector has a link to the encoder (struct intel_connector contains a
pointer to a struct intel_encoder).

> 2) intel_dp_detect() is called even though it's an HDMI monitor
>    connected to an HDMI jack.. It may be a bug specific to the
>    hardware I'm testing (attached its full dmesg).

We run all of the hotplug functions when any connector change is
detected; easier than trying to track what happened from the bits
visible from the interrupt.

I note that this patch does not include the necessary hooks for
Ivybridge; we'll need that included (and tested) for this to be
considered for kernel 3.1. I'd be surprised if it couldn't use
ironlake_write_eld just fine, so it should just be a matter of setting
the write_eld field and testing it on actual hardware.

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20110803/c210a337/attachment.pgp>

More information about the dri-devel mailing list