[Bug 40952] R100 firmware no longer loads

[bugzilla-daemon at bugzilla.kernel.org]

https://bugzilla.kernel.org/show_bug.cgi?id=40952





--- Comment #8 from Anonymous Emailer <anonymous at kernel-bugs.osdl.org>  2011-08-25 01:07:40 ---
Reply-To: gregkh at suse.de

On Wed, Aug 24, 2011 at 02:22:27PM -0700, Linus Torvalds wrote:
> On Wed, Aug 24, 2011 at 2:04 PM,  <bugzilla-daemon at bugzilla.kernel.org> wrote:
> >
> > --- Comment #3 from Michel Dänzer <michel at daenzer.net>  2011-08-24 21:03:48 ---
> > From Elimar Riesebieter (riesebie at lxtec.de):
> >
> > bisecting brought me to commit
> > 288d5abec8314ae50fe6692f324b0444acae8486. Reverting seems to work as
> > microcode is loaded with compiled in firmware and radeon kms driver.
> 
> Grr.
> 
> So _request_firmware() does this:
> 
>         if (WARN_ON(usermodehelper_is_disabled())) {
>                 dev_err(device, "firmware: %s will not be loaded\n", name);
>                 return -EBUSY;
>         }
> 
> which is reasonable, but it does mean that it will warn even if the
> firmware is built into the kernel.
> 
> On the one hand, that's really nice, because it implies a driver does
> a firmware load too early, at a point where it cannot do the generic
> firmware load.
> 
> On the other hand, it sucks, because it does disallow this situation
> that used to work, now that we actually do the sane thing and don't
> allow usermode helpers before init has been set up.
> 
> So I bet the attached patch fixes the R100 problem, but I'm not 100%
> happy with it.
> 
> Comments?

That patch looks good to me.

Any ideas on ways that this all could be rewritten to be "saner"?

greg k-h

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.