[PATCH] Fix wrong initializer for "locked" variable
Jesse Barnes
jbarnes at virtuousgeek.org
Thu Aug 25 09:22:30 PDT 2011
On Thu, 25 Aug 2011 15:37:45 +0200
Thomas Jarosch <thomas.jarosch at intra2net.com> wrote:
> Otherwise it just contains random memory.
>
> Issue detected by cppcheck.
>
> Signed-off-by: Thomas Jarosch <thomas.jarosch at intra2net.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index ee1d701..f6da4e4 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -878,7 +878,7 @@ static void assert_panel_unlocked(struct drm_i915_private *dev_priv,
> int pp_reg, lvds_reg;
> u32 val;
> enum pipe panel_pipe = PIPE_A;
> - bool locked = locked;
> + bool locked = true;
>
> if (HAS_PCH_SPLIT(dev_priv->dev)) {
> pp_reg = PCH_PP_CONTROL;
Hah yeah that's a good one, thanks for the fix.
Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org>
--
Jesse Barnes, Intel Open Source Technology Center
More information about the dri-devel
mailing list