drm_open doesn't lock before increasing dev->open_count

Dave Airlie airlied at redhat.com
Mon Feb 7 14:52:52 PST 2011


On Sun, 2011-02-06 at 19:24 +0200, adam zeira wrote:
> is this a problem? before trying to submit a solution I wanted to make sure with the experts
> 
> it seems open_count isn't locked and can cause problems
> 
> and if it is a problem, and needs to be solved, should locking be done or is it better implemented with the (as I understand standard) kref?
> 

Ickle?

1a72d65d6291ec248cbc5f05df2487edd714aba6 was your doing and I'm not
entirely sure you actually checked all the paths looking back.

Dave.





More information about the dri-devel mailing list