[BISECTED] commit 619efb1059 makes the MacBookPro2,2 screen flicker like its broken or half plugged in

[Alex Deucher]

On Tue, Feb 8, 2011 at 4:20 PM, Alex Deucher <alexdeucher at gmail.com> wrote:
> On Tue, Feb 8, 2011 at 3:52 PM, Justin P. Mattock
> <justinmattock at gmail.com> wrote:
>> With the current HEAD Im getting screen flickering really bad to point where
>> it looks like the screen is damaged and/or half plugged-in etc..
>>
>> the bisect pointed to here:
>>
>> commit 619efb105924d8cafa0c1dd9389e9ab506f5425d
>>
>> doing a git revert 619efb10592
>> gets the screen working properly again.
>> I havent looked much through the code to see if I can fix this. for the time
>> being I'll revert this on my machine with the current, until later on.
>
> The attached patch should fix it assuming I got your pci ids correct.
> I'm done with the pll stuff; too may fixes break other boards.  Just
> add a quirk table and be done with it.
>

The attached patch builds on the previous one and fixes an additional
regression.

Alex


> Alex
>
>>
>> lspci -vv shows my card info(let me know if you need anymore)
>>
>> 01:00.0 VGA compatible controller: ATI Technologies Inc M56P [Radeon
>> Mobility X1600] (prog-if 00 [VGA controller])
>>        Subsystem: Apple Computer Inc. MacBook Pro
>>        Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
>> Stepping- SERR- FastB2B- DisINTx+
>>        Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
>> <TAbort- <MAbort- >SERR- <PERR- INTx-
>>        Latency: 0, Cache Line Size: 256 bytes
>>        Interrupt: pin A routed to IRQ 42
>>        Region 0: Memory at 40000000 (32-bit, prefetchable) [size=128M]
>>        Region 1: I/O ports at 3000 [size=256]
>>        Region 2: Memory at 50300000 (32-bit, non-prefetchable) [size=64K]
>>        Expansion ROM at 50320000 [disabled] [size=128K]
>>        Capabilities: <access denied>
>>        Kernel driver in use: radeon
>>        Kernel modules: radeon
>>
>>
>> Justin P. Mattock
>>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-drm-radeon-kms-pll-quirk-cleanup.patch
Type: text/x-patch
Size: 4694 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20110209/498ee88e/attachment-0001.bin>