[PATCH 0/3] RFC: Common functions for GEM offset creation

[Alan Cox]

On Mon, 18 Jul 2011 19:20:56 -0500
Rob Clark <rob at ti.com> wrote:

> In the process of adding GEM support for OMAP DRM driver, I noticed that
> I was adding code for creating/freeing mmap offsets which was virtually
> identical to what was already duplicated in i915 and gma500 drivers.

The gma500 one was taken from i915 and I'd reach the same conclusion as
you - the current GMA500 driver (see staging git) has the mmap offset
patches broken out in gem_glue.c ready to do what you are proposing.

> Rather than duplicating the code a 3rd time, it seemed like a good idea
> to move it to the GEM core.

Agreed entirely.

> Note that I don't actually have a way to test psb or i915, but the
> changes seem straightforward enough.

Your patch doesn't apply versus gma500 but its trivial to remove it from
gem_glue.c once it goes into the mainstream GEM.

(The other bits in the gma500 glue are to allow for GEM objects backed by
things other than shmfs)

Alan