[Intel-gfx] [PATCH] drm/i915: Hold struct_mutex during hotplug processing

Keith Packard keithp at keithp.com
Wed Jul 27 02:21:24 PDT 2011


On Tue, 26 Jul 2011 12:12:25 -0700, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:

> I'd like to amend my reviewed by and say the lock shouldn't be held
> around the call to the drm helper function.  It queues some work that
> also takes the mode config lock, which will break.  So you can drop it
> before that...  Previously I had only checked our internal driver
> callbacks but missed that the lock was held across the helper too.

So the work may get executed immediately rather than being run later at
some point?

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20110727/7e8f8dbf/attachment.pgp>


More information about the dri-devel mailing list