[PATCH] savage: remove unecessary if statement
Nicolas Kaiser
nikai at nikai.net
Mon Jun 6 03:53:16 PDT 2011
* Greg Dietsche <Gregory.Dietsche at cuw.edu>:
> the code always returns ret regardless, so if(ret) check is unecessary.
/unecessary/unnecessary/
>
> Signed-off-by: Greg Dietsche <Gregory.Dietsche at cuw.edu>
Reviewed-by: Nicolas Kaiser <nikai at nikai.net>
Best regards,
Nicolas Kaiser
> ---
> drivers/gpu/drm/savage/savage_bci.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/savage/savage_bci.c b/drivers/gpu/drm/savage/savage_bci.c
> index bf5f83e..cb1ee4e 100644
> --- a/drivers/gpu/drm/savage/savage_bci.c
> +++ b/drivers/gpu/drm/savage/savage_bci.c
> @@ -647,9 +647,6 @@ int savage_driver_firstopen(struct drm_device *dev)
> ret = drm_addmap(dev, aperture_base, SAVAGE_APERTURE_SIZE,
> _DRM_FRAME_BUFFER, _DRM_WRITE_COMBINING,
> &dev_priv->aperture);
> - if (ret)
> - return ret;
> -
> return ret;
> }
>
More information about the dri-devel
mailing list