[PATCH 2/4] drm: add an fb creation ioctl that takes a pixel format

Alan Cox alan at lxorguk.ukuu.org.uk
Thu Jun 9 04:55:13 PDT 2011


> > You also don't need a headwer with a complete list of fourcc names in it,
> > that is the half the point of FourCC.
> 
> #define V4L2_PIX_FMT_RGB332  v4l2_fourcc('R', 'G', 'B', '1') /*  8
> RGB-3-3-2     */
> 
> See that V4L2 and v4l2? I'd rather not have them used in the drm

They are just helpers. The only thing that fourcc is is a 4 byte packed
value of four symbols.

> interface, either a DRM_ variant or a FOURCC_ variant that removes the
> V4L2. Also having it in a different include file to "videodev2.h", so
> yes we can pass FOURCC values but I'd rather we gave people a drm
> specific way to generate them or make a generic set of macros that don't
> include the V4L2 headers.

You need a macro to assemble fourcc codes and that seems to be about it -
so just an equivalent of the v4l2_fourcc macro.

Alan


More information about the dri-devel mailing list