[PATCH] r600g: remove useless call to u_upload_flush

Alex Deucher alexdeucher at gmail.com
Mon Jun 13 08:28:51 PDT 2011


On Fri, Jun 10, 2011 at 7:09 PM, Alex Deucher <alexdeucher at gmail.com> wrote:
> On Fri, Jun 10, 2011 at 7:08 PM, Alex Deucher <alexdeucher at gmail.com> wrote:
>> On Fri, Jun 10, 2011 at 2:10 PM, Rafael Monica <monraaf at gmail.com> wrote:
>>> I cannot test it now, but last time the flush call was removed it
>>> caused a major regression on Evergreen. See:
>>>
>>> https://bugs.freedesktop.org/show_bug.cgi?id=34008
>>>
>>> So please do not remove unless there are also no regressions on Evergreen.
>>
>> I just ran a piglit run on cedar with the patch and none of the piglit
>> tests mentioned in that bug failed, but the following tests did
>> regress:
>> fbo-incomplete-texture-03
>> hiz-stencil-read-fbo-d24s8
>
> FWIW, I'm not sure how consistently these tests pass or fail.
>

These seem to fail inconsistently with and without the patch, and I
didn't see any other regressions here, so I've gone ahead and
committed it.  Please let me know if it causes any regressions for you
or anyone else.

Alex

>>
>> Alex
>>
>>>
>>> Thanks.
>>> _______________________________________________
>>> dri-devel mailing list
>>> dri-devel at lists.freedesktop.org
>>> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>>>
>>
>


More information about the dri-devel mailing list