drm/i915: double unlock in intel_setup_overlay()

Chris Wilson chris at chris-wilson.co.uk
Thu Jun 23 12:20:55 PDT 2011

On Thu, 23 Jun 2011 21:06:16 +0300, Dan Carpenter <error27 at gmail.com> wrote:
> Smatch complains about the recent locking changes in
> intel_setup_overlay() that it unlocks twice on an error path.  I was
> also curious if we shouldn't call i915_gem_object_unpin() on that
> error path.  I don't know the drm code well enough to know about
> unpinning so I'm sending this bug report instead of patching it
> myself.  :)

Right, along the 945+ error path we need to unpin. Where did the locking
fixes land, I don't see the updated intel_overlay.c to comment upon the
double unlock?

Chris Wilson, Intel Open Source Technology Centre

More information about the dri-devel mailing list