[PATCH] drm: Fix EDID dump format

Jean Delvare khali at linux-fr.org
Mon Jun 27 06:32:34 PDT 2011


* print_hex_dump_bytes() already includes a log level, so we shouldn't
  add one. That log level is KERN_DEBUG so use the same for our header
  for consistency.
* print_hex_dump_bytes() properly puts a newline at the end of the
  last line, so there is no reason why we would add another one.

Signed-off-by: Jean Delvare <khali at linux-fr.org>
Cc: David Airlie <airlied at linux.ie>
---
 drivers/gpu/drm/drm_edid.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--- linux-3.0-rc4.orig/drivers/gpu/drm/drm_edid.c	2011-06-22 16:55:11.000000000 +0200
+++ linux-3.0-rc4/drivers/gpu/drm/drm_edid.c	2011-06-27 15:11:53.000000000 +0200
@@ -184,9 +184,9 @@ drm_edid_block_valid(u8 *raw_edid)
 
 bad:
 	if (raw_edid) {
-		printk(KERN_ERR "Raw EDID:\n");
-		print_hex_dump_bytes(KERN_ERR, DUMP_PREFIX_NONE, raw_edid, EDID_LENGTH);
-		printk(KERN_ERR "\n");
+		printk(KERN_DEBUG "Raw EDID:\n");
+		print_hex_dump_bytes("", DUMP_PREFIX_OFFSET,
+				     raw_edid, EDID_LENGTH);
 	}
 	return 0;
 }


-- 
Jean Delvare


More information about the dri-devel mailing list