[Bug 38364 ] - Ignoring invalid EDID block 1 do entire edid is invalid and not just block 1

[zaverel]

Hello

I just change from nvidia (nouveau) to ati (radeon)
for some reasons of noise .

And it's the same probleme with wrong edid block 1.

My tweak of drm_edid.c work again whatever it's nouveau or radeon
but again , i don't know if it's safe.

--- drm_edid.c    2011-06-10 22:37:36.605848000 +0200
+++ linux/drivers/gpu/drm/drm_edid.c    2011-06-13 13:04:43.136786102 +0200
@@ -292,7 +292,7 @@
                   block + (valid_extensions + 1) * EDID_LENGTH,
                   j, EDID_LENGTH))
                 goto out;
-            if (drm_edid_block_valid(block + (valid_extensions + 1) *
EDID_LENGTH)) {
+            if (drm_edid_block_valid(block + (valid_extensions + 0) *
EDID_LENGTH)) {
                 valid_extensions++;
                 break;
             }






log with my tweak (linux-gentoo-2.6.39-r2)


...
coretemp coretemp.2: TjMax is 97 C.
coretemp coretemp.3: TjMax is 97 C.
w83627ehf: Found W83667HG chip at 0x290
[drm:drm_edid_block_valid] *ERROR* Raw EDID:
<3>00 00 00 ff ff ff ff ff ff ff ff ff ff ff ff ff  ................
<3>ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff  ................
<3>ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff  ................
<3>ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff  ................
<3>ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff  ................
<3>ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff  ................
<3>ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff  ................
<3>ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff  ................

radeon 0000:02:00.0: VGA-1: EDID invalid.
[drm:drm_edid_block_valid] *ERROR* Raw EDID:
<3>00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
<3>00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
<3>00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
<3>00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
<3>00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
<3>00 00 00 00 00 00 00 00 00 00 00 00 00 7f ff ff  ................
<3>ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff  ................
<3>ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff  ................

radeon 0000:02:00.0: VGA-1: EDID invalid.
[drm] force priority to high
[drm] force priority to high
[drm] force priority to high
EXT4-fs (sda1): re-mounted. Opts: errors=remount-ro,commit=0
[drm:drm_edid_block_valid] *ERROR* Raw EDID:
<3>00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
<3>00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
<3>00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
<3>00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
<3>00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
<3>00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
<3>00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
<3>00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................

radeon 0000:02:00.0: VGA-1: EDID invalid.
[drm:drm_edid_block_valid] *ERROR* Raw EDID:
<3>00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
<3>00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
<3>00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
<3>00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
<3>00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
<3>00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
<3>00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
<3>00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................

radeon 0000:02:00.0: VGA-1: EDID invalid.