[PATCH] kms: Fix warning XNFprintf is deprecated (v2)
Michel Dänzer
michel at daenzer.net
Tue Mar 1 07:40:30 PST 2011
[Dropping dri-devel from CC again, X driver patches aren't really on
topic there]
On Sam, 2011-02-26 at 21:04 +0100, Sedat Dilek wrote:
> The first take of my patch missed the breakage against pre-1.10
> xservers and now I know XNFasprintf() is not a 1:1 replacement
> for XNFprintf().
What would be the point of replacing an API with one that is identical
except for the function name?
> The idea for the fix seemed to be so obvious, but as usual "really"
> test the patch you are sending to any ML.
Indeed. In particular, for a patch that is advertised to fix a warning,
the very least one should do is check it doesn't introduce other
warnings...
v2 pushed, thanks.
--
Earthling Michel Dänzer | http://www.vmware.com
Libre software enthusiast | Debian, X and DRI developer
More information about the dri-devel
mailing list