[Bug 26852] Build libkms against in-tree xf86drm.h

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=26852

Matt Turner <mattst88 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mattst88 at gmail.com

--- Comment #9 from Matt Turner <mattst88 at gmail.com> 2011-03-05 18:07:50 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> > Ping? As described in the initial report, there's no reason to prefer system
> > headers over those in the same source… I don't understand Sérgio's objection (I
> > fail to see what's illogical).
> 
> The illogical is, without that depending on kernel, you may try compile very
> new libdrm with a older kernel. 
> libdrm-2.4.21 needs kms on kernel but kernel <= 2.6.26 don't have it.   
> 
> my 2 cents

I think you're failing to understand the issue.

xf86drm.h is provided by libdrm. libkms (which is part of libdrm) uses
xf86drm.h, but the Makefile searches in /usr/include instead of the $(top_src)
directory, where libdrm's xf86drm.h is.

This is like if you have a library that consists of lib.c and lib.h, where
lib.c includes lib.h. The Makefile would be incorrect in using lib.h found in
/usr/include over the lib.h in the same folder as lib.c.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.