[PATCH] drm/radeon: fix problem with changing active VRAM size. (v2)

Michel Dänzer michel at daenzer.net
Tue Mar 15 01:24:21 PDT 2011


On Mon, 2011-03-14 at 12:50 +1000, Dave Airlie wrote: 
> From: Dave Airlie <airlied at redhat.com>
> 
> So we used to use lpfn directly to restrict VRAM when we couldn't
> access the unmappable area, however this was removed in
> 93225b0d7bc030f4a93165347a65893685822d70 as it also restricted
> the gtt placements. However it was only later noticed that this
> broke on some hw.
> 
> This removes the active_vram_size, and just explicitly sets it
> when it changes, TTM/drm_mm will always use the real_vram_size,
> and the active vram size will change the TTM size used for lpfn
> setting.
> 
> We should re-work the fpfn/lpfn to per-placement at some point
> I suspect, but that is too late for this kernel.
> 
> Hopefully this addresses:
> https://bugs.freedesktop.org/show_bug.cgi?id=35254
> 
> v2: fix reported useful VRAM size to userspace to be correct.
> 
> Signed-off-by: Dave Airlie <airlied at redhat.com>

Looks good, Dave. Thanks for getting rid of one of the *_vram_size
fields, those were getting out of hand.


-- 
Earthling Michel Dänzer           |                http://www.vmware.com
Libre software enthusiast         |          Debian, X and DRI developer


More information about the dri-devel mailing list