[Intel-gfx] [PATCH 3/5] drm/i915: add SNB and IVB video sprite support

Daniel Vetter daniel at ffwll.ch
Tue Nov 8 14:16:19 PST 2011


On Tue, Nov 08, 2011 at 10:57:03PM +0100, Daniel Vetter wrote:
> > +	/*
> > +	 * Clamp the width & height into the visible area.  Note we don't
> > +	 * try to scale the source if part of the visible region is offscreen.
> > +	 * The caller must handle that by adjusting source offset and size.
> > +	 */
> 
> Allowing the crtc dest rect to extend beyond that of the crtc and then refusing to
> properly adjust tiling is a bit inconsistent. I call design-by-committee
> on this one ;-)

Oops, that comment went fubar while transferring from brainwaves to bits.
Instead of "adjust tiling" it should be "adjust the source rectangle to
the restricted crtc dest".
-Daniel
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48


More information about the dri-devel mailing list