[PATCH] Fix wrong assumptions in cea_for_each_detailed_block v2

James Cloos cloos at jhcloos.com
Tue Nov 15 01:39:34 PST 2011


>>>>> "CS" == Christian Schmidt <schmidt at digadd.de> writes:

CS> The current logic misunderstands the spec about CEA 18byte descriptors.
CS> First, the spec doesn't state "detailed timing descriptors" but "18 byte
CS> descriptors", so any data record could be stored, mixed timings and
CS> other data, just as in the standard EDID.
CS> Second, the lower four bit of byte 3 of the CEA record do not contain
CS> the number of descriptors, but "the total number of DTDs defining native
CS> formats in the whole EDID [...], starting with the first DTD in the DTD
CS> list (which starts in the base EDID block)." A device can of course
CS> support non-native formats.

CS> As such the number can't be used to determine n, and the existing code
CS> will filter non-timing 18byte descriptors anyway.

CS> V2 removes an unused variable warning.

CS> Signed-off-by: Christian Schmidt <schmidt at digadd,de>

Tested-by: James Cloos <cloos at jhcloos.com>

Works fine here on top of Linus’ 7f80850d3f9f with a Radeon HD 4290 and
an hdmi-connected tv.

-JimC
-- 
James Cloos <cloos at jhcloos.com>         OpenPGP: 1024D/ED7DAEA6


CS> _______________________________________________
CS> dri-devel mailing list
CS> dri-devel at lists.freedesktop.org
CS> http://lists.freedesktop.org/mailman/listinfo/dri-devel


More information about the dri-devel mailing list