[PATCH] drm/i915: Use kcalloc instead of kzalloc to allocate array

Thomas Meyer thomas at m3y3r.de
Tue Nov 29 13:08:00 PST 2011

The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.

The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107

Signed-off-by: Thomas Meyer <thomas at m3y3r.de>

diff -u -p a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
--- a/drivers/gpu/drm/i915/intel_bios.c 2011-11-13 11:07:23.820113543 +0100
+++ b/drivers/gpu/drm/i915/intel_bios.c 2011-11-28 19:49:51.443206904 +0100
@@ -572,7 +572,7 @@ parse_device_mapping(struct drm_i915_pri
 		DRM_DEBUG_KMS("no child dev is parsed from VBT\n");
-	dev_priv->child_dev = kzalloc(sizeof(*p_child) * count, GFP_KERNEL);
+	dev_priv->child_dev = kcalloc(count, sizeof(*p_child), GFP_KERNEL);
 	if (!dev_priv->child_dev) {
 		DRM_DEBUG_KMS("No memory space for child device\n");

More information about the dri-devel mailing list