[PATCH 1/2] drm/ttm: add a way to bo_wait for either the last read or last write

Thomas Hellstrom thomas at shipmail.org
Sat Oct 8 04:10:13 PDT 2011


On 10/08/2011 12:26 PM, Ville Syrjälä wrote:
> On Fri, Oct 07, 2011 at 10:58:13AM +0200, Thomas Hellstrom wrote:
>    
>> Oh, and one more style comment below:
>>
>> On 08/07/2011 10:39 PM, Marek Olšák wrote:
>>      
>>> +enum ttm_buffer_usage {
>>> +    TTM_USAGE_READ = 1,
>>> +    TTM_USAGE_WRITE = 2,
>>> +    TTM_USAGE_READWRITE = TTM_USAGE_READ | TTM_USAGE_WRITE
>>> +};
>>>
>>>
>>>        
>> Please don't use enums for bit operations.
>>      
> Now I'm curious. Why not?
>
>    
Because it's inconsistent with how flags are defined in the rest of the 
TTM module.

/Thomas




More information about the dri-devel mailing list