[patch] drm/nouveau: testing the wrong variable

Ben Skeggs bskeggs at redhat.com
Mon Oct 17 23:20:48 PDT 2011


On Tue, 2011-10-18 at 09:07 +0300, Dan Carpenter wrote:
> memtimings is a valid pointer here, the intent was to test for
> kcalloc() failure.
I've queued it, thanks!

Ben.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
> 
> diff --git a/drivers/gpu/drm/nouveau/nouveau_perf.c b/drivers/gpu/drm/nouveau/nouveau_perf.c
> index 9f178aa..33d03fb 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_perf.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_perf.c
> @@ -239,7 +239,7 @@ nouveau_perf_init(struct drm_device *dev)
>  	if(version == 0x15) {
>  		memtimings->timing =
>  				kcalloc(entries, sizeof(*memtimings->timing), GFP_KERNEL);
> -		if(!memtimings) {
> +		if (!memtimings->timing) {
>  			NV_WARN(dev,"Could not allocate memtiming table\n");
>  			return;
>  		}




More information about the dri-devel mailing list