[patch] drm/i915: cleanup min_t() casting

Dan Carpenter dan.carpenter at oracle.com
Mon Oct 17 23:07:27 PDT 2011


Casting "len" from uin32_t to uint8_t in min_t() truncates the upper
bits.  It doesn't matter in this case because "len" is never more
than 0x1f, but Smatch warns about it, so let's change it.

Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 8230cf5..65897be 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -5702,7 +5702,7 @@ static void g4x_write_eld(struct drm_connector *connector,
 	if (!eld[0])
 		return;
 
-	len = min_t(uint8_t, eld[2], len);
+	len = min_t(uint32_t, eld[2], len);
 	DRM_DEBUG_DRIVER("ELD size %d\n", len);
 	for (i = 0; i < len; i++)
 		I915_WRITE(G4X_HDMIW_HDMIEDID, *((uint32_t *)eld + i));


More information about the dri-devel mailing list