[PATCH 1/3] drm/radeon/kms: use crtc-specific dpms functions in prepare and commit

Michel Dänzer michel at daenzer.net
Wed Oct 26 00:25:52 PDT 2011

On Die, 2011-10-25 at 22:40 -0400, Ilija Hadzic wrote: 
> it's better that radeon_crtc_commit and radeon_crtc_prepare call
> crtc-specific dpms functions instead of hard-coding them to
> radeon_crtc_dpms.

Is it really better? If it's always radeon_crtc_dpms anyway, this
obfuscates that fact (and introduces a guaranteed branch prediction
miss, but that probably doesn't matter here).

Earthling Michel Dänzer           |                   http://www.amd.com
Libre software enthusiast         |          Debian, X and DRI developer

More information about the dri-devel mailing list