[PATCH 08/23] drm/via: use drm_mm instead of drm_sman

Daniel Vetter daniel at ffwll.ch
Thu Oct 27 14:00:09 PDT 2011

On Thu, Oct 27, 2011 at 01:07:35PM +0200, Daniel Vetter wrote:
> Now that we are again in proper control of owner_list, we need to
> properly list_del it on free.
> Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>

Chris Wilson rightly complained that this doesn't explain the list_del
magic going on. New commit msg reads:

    To make the transition in a piece-wise and bisectable way possible,
    I've hijacked the ->owner_list from drm_sman. While transitioning, the
    list_add was done by the driver, while the list_del was still done by
    the dying sman code.
    Now that we are in full control of ->owner_list, do the list_del

He also noted the superflous additions of INIT_LIST_HEAD and the stale
comment about spinlock locking in the idr allocation (protected by
dev->struct_mutex) that I've copied over. All fixed up and pushed out for
the moment to my fdo repo:


Cheers, Daniel
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48

More information about the dri-devel mailing list