[PATCH] drm/edid: Don't pretend (badly) to support composite sync

Adam Jackson ajax at redhat.com
Wed Sep 21 07:12:11 PDT 2011


If hardware does require composite sync for a mode, it's out of luck
with current drivers, since none support that.  Just skip the mode
instead, there'll be others in the EDID.  (Unless there's not, in which
case, failing is correct anyway.)

While we're at it, hush the other mode support messages behind
DRM_DEBUG_KMS, they're too chatty for normal dmesg.

Signed-off-by: Adam Jackson <ajax at redhat.com>
---
 drivers/gpu/drm/drm_edid.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 7425e5c..a15f10b 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -849,11 +849,12 @@ static struct drm_display_mode *drm_mode_detailed(struct drm_device *dev,
 		return NULL;
 
 	if (pt->misc & DRM_EDID_PT_STEREO) {
-		printk(KERN_WARNING "stereo mode not supported\n");
+		DRM_DEBUG_KMS("stereo mode not supported\n");
 		return NULL;
 	}
 	if (!(pt->misc & DRM_EDID_PT_SEPARATE_SYNC)) {
-		printk(KERN_WARNING "composite sync not supported\n");
+		DRM_DEBUG_KMS("composite sync not supported\n");
+		return NULL;
 	}
 
 	/* it is incorrect if hsync/vsync width is zero */
-- 
1.7.6



More information about the dri-devel mailing list