[PATCH] drm/i915: properly compute dp dithering for user-created modes

Adam Jackson ajax at redhat.com
Tue Apr 10 06:46:53 PDT 2012

On 4/10/12 4:42 AM, Daniel Vetter wrote:
> We've only computed whether we need to fall back to 6bpc due to dp
> link bandwidth constrains in mode_valid, but not mode_fixup. Under
> various circumstances X likes to create new modes which then lack
> proper 6bpc flags (if required), resulting in mode_fixup failures and
> ultimately black screens.
> Chris Wilson pointed out that we still get things wrong for bpp > 24,
> but that should be fixed in another patch (and it'll be easier because
> this patch consolidates the logic).

Certainly an improvement.

Reviewed-by: Adam Jackson <ajax at redhat.com>

- ajax

More information about the dri-devel mailing list