[PATCH 1/2] drm/nouveau: Add lock on drm_helper_resume_force_mode

Peter Hüwe PeterHuewe at gmx.de
Fri Apr 13 17:59:32 PDT 2012


Am Samstag 14 April 2012, 02:52:19 schrieb Jonathan Nieder:
> Hi,
> 
> Peter Huewe wrote:
> > mode_config should be locked when calling drm_helper_resume_force_mode.
> > This patch adds the lock, similar to #927a2f119.
> 
> Does this fix a problem that has been observed in the wild, or only a
> theoretical one?
> 
> Curious,
> Jonathan

Only theoretical ;)
Since all other drivers always lock around drm_helper_resume_force_mode I 
guessed this is good practice.

And since problem area is quite similar to the one mentioned in #927a2f119 / 
234f78a683e 
http://git.kernel.org/?p=linux/kernel/git/stable/linux-
stable.git;a=commit;h=234f78a683e30d6d4628846fde4a822c0e385529
the bug might happen in the wild.


Thanks,
Peter


More information about the dri-devel mailing list