[PATCH] xf86drm.c: add counter for ioctl restarting

Adam Jackson ajax at redhat.com
Mon Apr 16 07:12:39 PDT 2012


On Mon, 2012-04-16 at 12:54 +0400, Anton V. Boyarshinov wrote:
> Hi
>  
> > Obviously if we have a dead gpu, we need to break out of this loop. But
> > detecting a dead gpu (and returning an appropriate error like EIO) is the
> > kernel's job.
> In my case gpu isn't really dead. It works after some ioctl skip. I
> understend that it is a driver bug in any case, but i thing that working
> around this bugs with proper logging (absent in this patch) much better
> than lockup.

But your workaround isn't harmless.  It adds new failure modes for other
cases that currently work.  That's worse, not better.

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20120416/a7a3cafe/attachment.pgp>


More information about the dri-devel mailing list